[AURON #1907][CI] Fix YAML syntax error and restore TPCDS CI execution #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yew1eb
force-pushed
the
AURON_1907
branch
2 times, most recently
from
c027c08 to
3648a8a
Compare
yew1eb
changed the title
yew1eb
force-pushed
the
AURON_1907
branch
4 times, most recently
from
5cc2c6a to
635790e
Compare
yew1eb
changed the title
Contributor
Author
cxzl25
approved these changes
Jan 19, 2026
yew1eb
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix YAML syntax errors in the TPCDS CI workflow and restore its execution by addressing several integration issues.
Changes:
- Removed the
build-validatorjob and switched to using maven artifacts for the integration test dependencies - Added codegen ID normalization in plan stability checker to handle Scala 2.12/2.13 differences
- Updated 40+ golden files to normalize codegen IDs from specific numbers to 'X'
- Increased driver memory from 5g to 8g and memory overhead from 3GB to 4GB
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/tpcds-reusable.yml |
Removed build-validator job, added maven artifacts download, updated test execution command |
dev/auron-it/src/main/scala/org/apache/auron/integration/tpcds/TPCDSSuite.scala |
Added regenGoldenFiles check to plan validation logic |
dev/auron-it/src/main/scala/org/apache/auron/integration/comparison/PlanStabilityChecker.scala |
Added regex to normalize codegen IDs in query plans |
dev/auron-it/src/main/resources/tpcds-plan-stability/spark-3.5/q*.txt |
Updated golden files with normalized codegen IDs (40+ files) |
dev/auron-it/run-it.sh |
Increased driver memory and overhead allocations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1907
Rationale for this change
What changes are included in this PR?
tpcds-reusable.ymlblocking TPCDS CI execution.auron-itintegration in CI became ineffective after recent PR merges.Are there any user-facing changes?
How was this patch tested?